Skip to content

chore(resources): asset cleanup, rename, and folder reorg - #329

Open
gmmcosta15 wants to merge 2 commits into
fix/intro-gif-boot-scopefrom
refactor/resource-layout
Open

gmmcosta15 wants to merge 2 commits into
fix/intro-gif-boot-scopefrom
refactor/resource-layout

Conversation

@gmmcosta15

@gmmcosta15 gmmcosta15 commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

Description

  • Code refactor

Cleans up lib/ui/resources: consistent English snake_case filenames and prunes dead weight, enabled by the BlocksPixmap/Icon enum (#316-#327) making renames a 3-place edit instead of a repo-wide literal hunt.

  • Deleted 59 dead SVGs (50 fully orphaned, 3 qrc-declared but unused, 6 caught by the new guard test)
  • Renamed 24 assets: spaces, typos, casing, hyphens/_icon suffixes, non-English name, leading-digit wifi files
  • Added test_no_orphan_assets_on_disk guard test to catch this drift going forward
  • Reorganized the flat media/btn_icons/ directory into 14 subfolders mirroring the .qrc prefixes (86 files moved), updated all references in icon_resources.qrc, blocks_pixmap.py, and the hand-patched .ui/_ui.py pairs

Motivation

Prior PRs left dead/inconsistently-named assets undetected (no reverse check existed). This is the deferred cleanup pass, done last so it wouldn't conflict with the stack.

@gmmcosta15 gmmcosta15 self-assigned this Sep 3, 2026
@gmmcosta15
gmmcosta15 requested a review from HugoCLSC September 3, 2026 10:06
@gmmcosta15
gmmcosta15 force-pushed the refactor/resource-layout branch 2 times, most recently from 06a9e1b to 7039363 Compare September 3, 2026 10:18
@gmmcosta15
gmmcosta15 marked this pull request as ready for review September 3, 2026 10:20
@gmmcosta15
gmmcosta15 removed this pull request from stack #330 September 28, 2026 12:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant